Implement Chunk#head to Avoid Version Specific Issues With Scala Collections Library
#4441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mijicd
approved these changes
Nov 24, 2020
atooni
pushed a commit
to blended-zio/zio
that referenced
this pull request
Dec 1, 2020
…llections Library (zio#4441) * implement head * remove final modifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4438.
On Scala version 2.13.0 and 2.13.1
Chunk#headthrows aNoSuchMethodErrorfromscala.collection.IndexedSeqOps. This issue does not occur on later Scala versions and also seems to be quite specific (e.g.lastworks fine). We may have users who are stuck on various Scala versions because of other dependencies so I think it makes sense to address this if possible. We can do so by just reimplementingheadourselves in terms ofapply.