Support use of @accessible macro with implicits (#4466) #4467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@ioleo .. Are you able to review/approve this ? |
ioleo
previously approved these changes
Feb 17, 2021
|
@nadenf Thanks for working on this and apologies for the delay! Can you merge upstream changes to trigger CI and then we can get this in? |
adamgfraser
approved these changes
Mar 3, 2021
ioleo
approved these changes
Mar 3, 2021
|
@adamgfraser can you merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing automated tests pass but not sure how useful they are given that never picked up the bug described in #4466.
However manual testing with various combinations of implicits and normal parameters appear to work fine.