Add includeCase parameter to DefaultTestReporter.render #4486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88237e3 to
3a1ad0c
Compare
2adcde0 to
2aa95c1
Compare
Suppress the second Cause during ZTestFramework output.
Currently, the output is of the structure:
- SuiteName
- Test label
Fiber failed.
<snip>
Ran 1 test in 2 s 167 ms: 0 succeeded, 0 ignored, 1 failed
- SuiteName
- Test label
Fiber failed.
<snip>
Done
This obscures the individual test failures, the summary at the very end
should only have the SuiteName and Test label, with stacktrace
suppressed, to highlight which tests are having a problem to make it
easier to scroll up in the test log.
With this alteration, the output of the test structure now looks like:
- SuiteName
- Test label
Fiber failed.
<snip>
Ran 1 test in 2 s 167 ms: 0 succeeded, 0 ignored, 1 failed
- SuiteName
- Test label
Done
(notice, the second `Fiber failed.` and stacktrace have been omitted)
2aa95c1 to
012f86e
Compare
adamgfraser
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress the second Cause during ZTestFramework output.
NB: This is not a binary compatible change, if that is desired I can attempt to ensure compatibility.
An alternate implementation of this feature could be to duplicate the
rendermethod.Currently, the output is of the structure:
This obscures the individual test failures, the summary at the very end
should only have the SuiteName and Test label, with stacktrace
suppressed, to highlight which tests are having a problem to make it
easier to scroll up in the test log.
With this alteration, the output of the test structure now looks like:
(notice, the second
Fiber failed.and stacktrace have been omitted)