Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add support for scala 3.0.0-M2 #4483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2020
Merged

Add support for scala 3.0.0-M2 #4483

merged 1 commit into from
Dec 10, 2020

Conversation

@scalavision
Copy link
Contributor

Adding support for scala 3.0.0-M2 and izumi-reflect 1.0.0-M11. I upgraded the CompilerVariants test according to what was defined as breaking changes in the scala 3.0.0-M2 release. As scalajs now is supported by Scala 3 it would be very nice to get a new release of the excellent ZIO library as well :-)

Scala 3.0.0-M2 breaking changes are defined here:

https://github.com/lampepfl/dotty/releases/tag/3.0.0-M2

@scalavision scalavision force-pushed the add-support-for-scala3-M2 branch 2 times, most recently from 5ce9a58 to 6d48749 Compare December 4, 2020 19:29
@scalavision
Copy link
Contributor Author

Any idea why it fails? I am not able to see the logs. Running them locally seems to work.

Ran 426 tests in 1 m 52 s: 420 succeeded, 6 ignored, 0 failed

I also get an error from semtanticdb option when running the tests but it doesn't seem to affect anything:

[error] bad option: -P:semanticdb:synthetics:on
[error] one error found

@adamgfraser
Copy link
Contributor

adamgfraser commented Dec 8, 2020 •
edited
Loading

@scalavision Looks like there was an error with the izumi-reflect dependency on Scala 3.

@adamgfraser
Copy link
Contributor 

[error] sbt.librarymanagement.ResolveException: Error downloading dev.zio:izumi-reflect_3.0.0-M1:1.0.0-M11
[error]   Not found
[error]   Not found
[error]   not found: /home/circleci/.ivy2/local/dev.zio/izumi-reflect_3.0.0-M1/1.0.0-M11/ivys/ivy.xml
[error]   not found: https://repo1.maven.org/maven2/dev/zio/izumi-reflect_3.0.0-M1/1.0.0-M11/izumi-reflect_3.0.0-M1-1.0.0-M11.pom
[error] 	at lmcoursier.CoursierDependencyResolution.unresolvedWarningOrThrow(CoursierDependencyResolution.scala:258)
[error] 	at lmcoursier.CoursierDependencyResolution.$anonfun$update$38(CoursierDependencyResolution.scala:227)
[error] 	at scala.util.Either$LeftProjection.map(Either.scala:573)
[error] 	at lmcoursier.CoursierDependencyResolution.update(CoursierDependencyResolution.scala:227)
[error] 	at sbt.librarymanagement.DependencyResolution.update(DependencyResolution.scala:60)
[error] 	at sbt.internal.LibraryManagement$.resolve$1(LibraryManagement.scala:53)
[error] 	at sbt.internal.LibraryManagement$.$anonfun$cachedUpdate$12(LibraryManagement.scala:103)
[error] 	at sbt.util.Tracked$.$anonfun$lastOutput$1(Tracked.scala:73)
[error] 	at sbt.internal.LibraryManagement$.$anonfun$cachedUpdate$20(LibraryManagement.scala:116)
[error] 	at scala.util.control.Exception$Catch.apply(Exception.scala:228)
[error] 	at sbt.internal.LibraryManagement$.$anonfun$cachedUpdate$11(LibraryManagement.scala:116)
[error] 	at sbt.internal.LibraryManagement$.$anonfun$cachedUpdate$11$adapted(LibraryManagement.scala:97)
[error] 	at sbt.util.Tracked$.$anonfun$inputChangedW$1(Tracked.scala:219)
[error] 	at sbt.internal.LibraryManagement$.cachedUpdate(LibraryManagement.scala:130)
[error] 	at sbt.Classpaths$.$anonfun$updateTask0$5(Defaults.scala:3485)
[error] 	at scala.Function1.$anonfun$compose$1(Function1.scala:49)
[error] 	at sbt.internal.util.$tilde$greater.$anonfun$$u2219$1(TypeFunctions.scala:62)
[error] 	at sbt.std.Transform$$anon$4.work(Transform.scala:68)
[error] 	at sbt.Execute.$anonfun$submit$2(Execute.scala:282)
[error] 	at sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:23)
[error] 	at sbt.Execute.work(Execute.scala:291)
[error] 	at sbt.Execute.$anonfun$submit$1(Execute.scala:282)
[error] 	at sbt.ConcurrentRestrictions$$anon$4.$anonfun$submitValid$1(ConcurrentRestrictions.scala:265)
[error] 	at sbt.CompletionService$$anon$2.call(CompletionService.scala:64)
[error] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[error] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[error] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[error] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[error] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[error] 	at java.lang.Thread.run(Thread.java:748)
[error] (coreJVM / update) sbt.librarymanagement.ResolveException: Error downloading dev.zio:izumi-reflect_3.0.0-M1:1.0.0-M11
[error]   Not found
[error]   Not found
[error]   not found: /home/circleci/.ivy2/local/dev.zio/izumi-reflect_3.0.0-M1/1.0.0-M11/ivys/ivy.xml
[error]   not found: https://repo1.maven.org/maven2/dev/zio/izumi-reflect_3.0.0-M1/1.0.0-M11/izumi-reflect_3.0.0-M1-1.0.0-M11.pom
[error] Total time: 2 s, completed Dec 7, 2020 5:12:00 PM

@jczuchnowski
Copy link
Member

You need to update Scala 3 version in .circleci/config.yml

@scalavision scalavision force-pushed the add-support-for-scala3-M2 branch from 6d48749 to 0cb50bb Compare December 8, 2020 19:42
@scalavision
Copy link
Contributor Author

nice, thanks, let's see if this works :-)

@jczuchnowski
Copy link
Member

Awesome! We need ZIO 1.0.4!

jczuchnowski
jczuchnowski approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@jczuchnowski jczuchnowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jczuchnowski jczuchnowski mentioned this pull request Dec 8, 2020
Closed
@adamgfraser adamgfraser merged commit 7bcc0f7 into zio:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mijicd mijicd Awaiting requested review from mijicd

@softinio softinio Awaiting requested review from softinio

2 more reviewers

@jczuchnowski jczuchnowski jczuchnowski approved these changes

@adamgfraser adamgfraser adamgfraser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scalavision @adamgfraser @jczuchnowski