update to scala 3.0.0-M3 #4516
update to scala 3.0.0-M3 #4516
Conversation
|
@scalavision Are you able to update this now that a new version of |
|
I think this should work, the izumi-reflect version is correctly set at version When trying to test:compile at version 3.0.0-M3, I also get this strange error: I wonder if this is the dotty build not being able to propagate dependencies correctly. I have used both zio and zio-streams a bit locally without any problems, but there are a lot of bugs in the Scala 3 compiler still, so I don't think one can rely on everything here yet. |
|
Doesn't look like there are any merge conflicts currently so don't think you need to rebase so couldn't hurt. Don't really know what to make of that error. |
c8f564a to
094950f
Compare
|
I've renamed to |
|
I have added a bug report with a minimal example here in Dotty: |
094950f to
943ea05
Compare
|
@adamgfraser , could you take a look again, is there anything else that needs change? It seemed to be a red flag on the ci test for dotty_jdk8, but I wasn't able to see what was wrong. The problem with shadowing of package name turned out to be well defined behavior according to the scala specification. I renamed the arg in |
There was a problem hiding this comment.
@scalavision I think this is fine for now but I do still think there is a potential issue with force.
You're right that the definition of zio in the argument to force shadows the definition of the zio package object, so we shouldn't be able to refer to zio.InterruptStatus without qualifying it using _root_. However, we're not doing that but just trying to refer to InterruptStatus directly, which should already be in scope. This worked on all versions of Scala 2 as well as all versions of Scala 3 before this so unless there has been some discussion about how this is an intentional change I think it is worth at least raising the issue.
Do you want to do so? I am happy to as well.
|
just go ahead @adamgfraser :-) I think I understand what you mean, and it surprised me that the compiler didn't automatically search across all available namespaces in scope (as I would describe it). I also agree, it was surprising that this suddenly should break. However, I feel I don't have the deep knowledge into the compiler semantics that I can raise this issue in a convincing way. Anyways, thanks for all the help getting this merged! I am really looking forward to the next release of this amazing library :-) |
|
@scalavision Okay, will do and copy you. Thanks for your work on this! I know there are a lot of people who are eager to get a release for the latest version of Scala 3. |
This is dependent on izumi-reflect:
zio/izumi-reflect#118