Thanks to visit codestin.com
Credit goes to github.com

Skip to content

zio-test: assert - further refinement to macro based expression capture (Scala 2.x) #4560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2021
Merged

zio-test: assert - further refinement to macro based expression capture (Scala 2.x) #4560

merged 2 commits into from
Jan 23, 2021

Conversation

@dkarlinsky
Copy link
Contributor

@dkarlinsky dkarlinsky commented Jan 16, 2021 •
edited
Loading

Further refinement on #4533
Cleaner rendering of:

  • if/else
  • match
  • method/ctor calls with default arguments
  • new
  • throw
  • anonymous functions, especially with _ argument placeholders

@dkarlinsky dkarlinsky changed the title zio-test: assert - more refinement to macro based expression extraction (Scala 2.x) zio-test: assert - more refinement to macro based expression capture (Scala 2.x) Jan 16, 2021
@dkarlinsky dkarlinsky changed the title zio-test: assert - more refinement to macro based expression capture (Scala 2.x) zio-test: assert - further refinement to macro based expression capture (Scala 2.x) Jan 17, 2021
@dkarlinsky dkarlinsky marked this pull request as ready for review January 17, 2021 09:58
@adamgfraser
Copy link
Contributor

@dkarlinsky Can you merge upstream changes?

@hmemcpy Is there anything we need to do here for the functionality you are providing in the Intellij plugin related to this?

@hmemcpy
Copy link
Contributor

hmemcpy commented Jan 21, 2021

@adamgfraser nothing else, thanks!

adamgfraser
adamgfraser previously approved these changes Jan 21, 2021
View reviewed changes
@dkarlinsky dkarlinsky force-pushed the zio-test-show-expr-macro-refinement branch from ed89167 to 635949a Compare January 23, 2021 09:16
@adamgfraser adamgfraser merged commit 55adcc2 into zio:master Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adamgfraser adamgfraser adamgfraser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dkarlinsky @adamgfraser @hmemcpy