Check That Both Queues Are Shutdown In Implementation of isShutdown in Queue#bothWithM #4635
Conversation
| def size: UIO[Int] = self.size.zipWithPar(that.size)(math.max) | ||
| def shutdown: UIO[Unit] = self.shutdown.zipWithPar(that.shutdown)((_, _) => ()) | ||
| def isShutdown: UIO[Boolean] = self.isShutdown | ||
| def isShutdown: UIO[Boolean] = self.isShutdown.zipWithPar(that.isShutdown)(_ && _) |
There was a problem hiding this comment.
Actually should this be && or ||? You're going to get interrupted if you try to pull from a composite queue if either queue has been shutdown, so in that sense || seems like the wrong semantics. But on the other hand shutdown of the composite queue hasn't been completed until both queues have been shut down.
|
@jdegoes Do you have a sense of what the right semantics are here or should we just close this since these operators are deprecated anyway? |
|
@adamgfraser |
|
Okay, then I think reporting that the combined queue is shutdown if either of the original queues is shut down is the correct semantic. Updated to reflect that now. |
I believe we should be checking if both queues have been shutdown here.