Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve Scala Native integration #4653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2021
Merged

Improve Scala Native integration #4653

merged 1 commit into from
Feb 3, 2021

Conversation

@lolgab
Copy link
Contributor

@lolgab lolgab commented Feb 3, 2021

  • Copy-paste JS version to align latest improvements
  • Use scala-native-loop Timer instead of Scala.js compatibility layer

@lolgab
Improve Scala Native integration
ec0000b 
- Copy-paste JS version to align latest improvements
- Use scala-native-loop Timer instead of Scala.js compatibility layer
@lolgab lolgab force-pushed the scala-native-improvements branch from e39fcbf to ec0000b Compare February 3, 2021 11:33
@lolgab lolgab marked this pull request as ready for review February 3, 2021 12:25
adamgfraser
adamgfraser approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@adamgfraser adamgfraser merged commit 7489891 into zio:master Feb 3, 2021
@lolgab lolgab deleted the scala-native-improvements branch February 3, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mijicd mijicd Awaiting requested review from mijicd

@softinio softinio Awaiting requested review from softinio

1 more reviewer

@adamgfraser adamgfraser adamgfraser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lolgab @adamgfraser