Add ZIO#tapSome #4676
Merged
Add ZIO#tapSome #4676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
adamgfraser
previously approved these changes
Feb 11, 2021
There was a problem hiding this comment.
@kubukoz Looks good! Not sure why the rest of the CI checks aren't running. Can you try merging upstream changes in case there were any changes to CI settings that aren't incorporated in your version.
|
Rebased to latest master, let's see ;) |
|
Apparently... doesn't work |
mijicd
reviewed
Mar 3, 2021
Comment on lines
+1827
to
+1828
| final def tapSome[R1 <: R, E1 >: E](f: PartialFunction[A, ZIO[R1, E1, Any]]): ZIO[R1, E1, A] = | ||
| self.tap(f.applyOrElse(_, (_: A) => ZIO.unit)) |
There was a problem hiding this comment.
Super nitpick, I'd use ZIO.unitFn.
|
@kubukoz Thank you for your contribution and sorry for the delay on getting this merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.