ZIO Stream: Implement ZStream#changes #4697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdegoes
reviewed
Mar 16, 2021
| * previous element emitted, using natural equality to determine whether two | ||
| * elements are equal. | ||
| */ | ||
| def changes: ZStream[R, E, O] = |
There was a problem hiding this comment.
Would dedup be a better name? (Not sure about that.)
There was a problem hiding this comment.
Yes I wondered about that too. This is distinctUntilChanged in reactive streams and removeDuplicates in some other frameworks so deduplicate is definitely reasonable. The slightly tricky thing is it doesn't necessary remove all duplicates in the sense that if the stream emits A, A, B, A the resulting stream will be A, B, A so you will still have two A values just not two consecutive ones.
There was a problem hiding this comment.
I'm ok with changes especially if there is no clear pattern.
jdegoes
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.