Upstream Generators From ZIO Test Refined Module #4600 #4723
Conversation
| /** | ||
| * A generator of alpha characters. | ||
| */ | ||
| val alphaChar: Gen[Random, Char] = |
There was a problem hiding this comment.
Can we alphabetize please? Otherwise looks great!
There was a problem hiding this comment.
Sorry, didn't get what you mean.
Alphabetize random char generator?
There was a problem hiding this comment.
Oh sorry. Just put the constructors in alphabetical order with all the existing constructors. So like right now whiteSpaceChars is near the top of the file above the existing alphaNumericString generator but it should be towards the end of the file after the weighted constructor. It doesn't actually change the logic of your implementation but just makes it easier for users and contributors to find things in the file, especially when it is a large one like this one.
There was a problem hiding this comment.
Ok, I think now they are alphabetized:)
Implementation for #4600. Same to #4721, but commits from personal github.
Moved three generators from CharInstances to Gen
However, I'm not sure about javadoc description and shrinks. Please, check them out.