assertCompletesM #4740
Merged
assertCompletesM #4740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@emarx you will need to run |
|
Thanks, @regiskuckaertz! Ran |
adamgfraser
reviewed
Feb 28, 2021
| * Asserts that the given test was completed. | ||
| */ | ||
| val assertCompletesM: UIO[TestResult] = | ||
| assertMImpl(UIO.succeed(true))(Assertion.isTrue) |
There was a problem hiding this comment.
Can actually be succeedNow for internal implementations like this.
adamgfraser
reviewed
Feb 28, 2021
| } | ||
|
|
||
| object Sized { | ||
|
|
There was a problem hiding this comment.
Whoops, hadn't switched the scalafmt
adamgfraser
suggested changes
Feb 28, 2021
|
Thanks for your review, @adamgfraser! Comments addressed. |
adamgfraser
approved these changes
Feb 28, 2021
|
Looks great! Will merge after all the checks pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function
assertCompletesMto complement the existingassertCompletes