Thanks to visit codestin.com
Credit goes to github.com

Extract Gen implement #4742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

adamgfraser merged 7 commits into zio:master from jxnu-liguobin:p4601

Mar 4, 2021

Contributor

jxnu-liguobin commented Feb 26, 2021

No description provided.

CLAassistant commented Feb 26, 2021 •

edited

Loading

All committers have signed the CLA.


          extract gen implementation

0ffb28c

jxnu-liguobin force-pushed the p4601 branch from 143e661 to 0ffb28c Compare

February 26, 2021 09:45


          Extract Gen implement

321878d

jdegoes reviewed

View reviewed changes

Member

jdegoes left a comment

Looks good to me, @adamgfraser may want to take a look!

adamgfraser reviewed

View reviewed changes

test-refined/shared/src/main/scala/zio/test/refined/BooleanInstances.scala Outdated Show resolved Hide resolved

adamgfraser reviewed

View reviewed changes

test-refined/shared/src/main/scala/zio/test/refined/BooleanInstances.scala Outdated Show resolved Hide resolved

adamgfraser reviewed

View reviewed changes

test-refined/shared/src/main/scala/zio/test/refined/CollectionInstances.scala Outdated Show resolved Hide resolved

adamgfraser reviewed

View reviewed changes

test-refined/shared/src/main/scala/zio/test/refined/CharInstances.scala Outdated Show resolved Hide resolved

adamgfraser reviewed

View reviewed changes

test-refined/shared/src/main/scala/zio/test/refined/CollectionInstances.scala Outdated Show resolved Hide resolved

adamgfraser reviewed

View reviewed changes

test-refined/shared/src/main/scala/zio/test/refined/CollectionInstances.scala Outdated Show resolved Hide resolved

adamgfraser suggested changes

View reviewed changes

Contributor

adamgfraser left a comment

Looks good. A couple of comments on the implementation but definitely going in the right direction!


          Merge branch 'master' into p4601

b6210f6

# Conflicts:
#	test-refined/shared/src/main/scala/zio/test/refined/CharInstances.scala

jxnu-liguobin requested a review from adamgfraser

March 1, 2021 02:45

jxnu-liguobin added 2 commits

March 1, 2021 13:26


          exec fix

9865aa2


          Merge branch 'master' into p4601

1afeeaa

adamgfraser reviewed

View reviewed changes

test-refined/shared/src/main/scala/zio/test/refined/CollectionInstances.scala Outdated Show resolved Hide resolved

adamgfraser reviewed

View reviewed changes

test-refined/shared/src/main/scala/zio/test/refined/StringInstances.scala Outdated Show resolved Hide resolved

adamgfraser previously approved these changes

View reviewed changes

Contributor

adamgfraser left a comment

Looking really good! A few more changes and this will be ready to go.


          Optimize code

41ddb2a

jxnu-liguobin dismissed adamgfraser’s stale review via

41ddb2a

March 3, 2021 06:03


          Empty Commit to rebuild

c089963

jxnu-liguobin requested a review from adamgfraser

March 4, 2021 02:48

adamgfraser approved these changes

View reviewed changes

Contributor

adamgfraser left a comment

Looks fantastic! Thanks again for working on this!

adamgfraser merged commit a182362 into zio:master

jxnu-liguobin deleted the p4601 branch

March 16, 2021 08:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet