Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Flatten exit in supervisor unsafeOnEnd #4752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2021
Merged

Flatten exit in supervisor unsafeOnEnd #4752

merged 1 commit into from
Mar 1, 2021

Conversation

@mikearnaldi
Copy link
Contributor

As per discussion in Discord unsafeOnEnd should get the actual exit Exit[E,A] and not Exit[Nothing, Exit[E,A]] that is provided by FiberContext#onDone this PR uses flatten to re-enstablish the correct exit value

adamgfraser
adamgfraser approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@adamgfraser adamgfraser merged commit 809eac7 into zio:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adamgfraser adamgfraser adamgfraser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mikearnaldi @adamgfraser