-
Couldn't load subscription status.
- Fork 1.4k
Annotation for throwing #4837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotation for throwing #4837
Conversation
76fe861 to
55247e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Good to go when compilation issues are resolved.
|
I will get back to this these days, it seems is more time consuming than I thought since apparently there is a bug causing that warning in 2.11. |
|
It appears that on scala 211 with java8 it will throw an warning if it finds an annotation on a Now, the This still adds values since:
I don't have the resources to go more into macros and fix that warning for scala 211. I suppose that I have to expand that annotation and make it Please let me know what you think. Thanks |
|
@octavz I think your proposal makes sense. |
55247e9 to
753d959
Compare
|
I removed the Thank you. |
docs/howto/howto_macros.md
Outdated
| @accessible | ||
| object Module { | ||
| trait Service { | ||
| def pureMethog(v: Something): SomethingElse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| def pureMethog(v: Something): SomethingElse | |
| def pureMethod(v: Something): SomethingElse |
753d959 to
db01650
Compare
|
@octavz Can you resolve conflicts? |
|
@adamgfraser it is done |
Resolves #4804