Implement noneOrFail #4841 #4851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
5904030 to
195011e
Compare
adamgfraser
reviewed
Mar 30, 2021
| * If the option is empty it succeeds with Unit. | ||
| * If the option is defined it fails with an error adapted with f. | ||
| */ | ||
| def noneOrFail[E, O](o: Option[O], f: O => E): IO[E, Unit] = |
There was a problem hiding this comment.
I would think noneOrFail would fail with O and noneOrFailWith would allow specifying a function to transform the error type.
There was a problem hiding this comment.
I updated the code. Now the 2 methods are available.
|
makes sense, I'll try that tomorrow
…On Tue, Mar 30, 2021 at 2:57 PM Adam Fraser ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In core/shared/src/main/scala/zio/ZIO.scala
<#4851 (comment)>:
> @@ -3649,6 +3649,14 @@ object ZIO extends ZIOCompanionPlatformSpecific {
*/
val none: UIO[Option[Nothing]] = succeedNow(None)
+ /**
+ * Lifts an Option into a IO.
+ * If the option is empty it succeeds with Unit.
+ * If the option is defined it fails with an error adapted with f.
+ */
+ def noneOrFail[E, O](o: Option[O], f: O => E): IO[E, Unit] =
I would think noneOrFail would fail with O and noneOrFailWith would allow
specifying a function to transform the error type.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4851 (review)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFK6ZDIHMKTCMMZ7MIE2DTTGHCUVANCNFSM4Z76GMQA>
.
|
16d0378 to
ef675fa
Compare
|
hey @adamgfraser , anything still needed before the merge ? |
adamgfraser
suggested changes
Apr 6, 2021
|
Thanks for the review ! I'll have a look at the changes you requested, I think they all make sense. I don't know when I can handle these, this week is going to be quite busy. |
|
I rebased from master branch, currified, and added an alias in RIO and Task. The Task alias really makes sense ! Anything else @adamgfraser ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.