Scala 3.0.0-RC2 #4874
Merged
Scala 3.0.0-RC2 #4874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤔 [error] -- Error: /home/runner/work/zio/zio/test/shared/src/main/scala/zio/test/DefaultMutableRunnableSpec.scala:22:6
[error] 22 |class DefaultMutableRunnableSpec extends MutableRunnableSpec(ZLayer.identity[TestEnvironment], TestAspect.identity)
[error] | ^^^^^^^^^^^^^^^^^^^^^^^^^^
[error] |class DefaultMutableRunnableSpec cannot be instantiated since it has conflicting base type arguments zio.test.Annotations & zio.test.environment.Live & zio.test.Sized &
[error] | zio.test.environment.TestClock
[error] | & zio.test.TestConfig & zio.test.environment.TestConsole &
[error] | zio.test.environment.TestRandom
[error] | & zio.test.environment.TestSystem and zio.ZEnv |
|
@sideeffffect It looks like adding a type alias for the intersection types resolves the issue. I submitted a PR against your branch with that change. I will open an issue with the Scala 3 team but that should get us going for now. |
|
Commented on scala/scala3#11995, which I believe is the same issue. |
Add Type Alias
|
Thanks Adam! ❤️ |
|
Dotty build seemed to have failed only on a flaky test 😄 Could somebody restart it, please? |
adamgfraser
reviewed
Apr 6, 2021
test-tests/shared/src/test/scala/zio/test/MutableRunnableSpecSpec.scala
Outdated
Show resolved
Hide resolved
adamgfraser
reviewed
Apr 6, 2021
test-tests/shared/src/test/scala/zio/test/MutableRunnableSpecSpec.scala
Outdated
Show resolved
Hide resolved
|
@sideeffffect Not flakiness but I think we are running into #4802. I suggested a couple of changes that will resolve the issue for now. |
Co-authored-by: Adam Fraser <[email protected]>
# Conflicts: # .github/workflows/ci.yml # project/BuildHelper.scala
|
Green 🎉 |
adamgfraser
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.