Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Test layer is not shared between tests anymore #5016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 8, 2021
Merged

Test layer is not shared between tests anymore #5016

merged 5 commits into from
May 8, 2021

Conversation

@fokot
Copy link
Contributor

@fokot fokot commented Apr 23, 2021 •
edited
Loading

adamgfraser
adamgfraser previously approved these changes Apr 24, 2021
View reviewed changes
Copy link
Contributor

@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@adamgfraser
Copy link
Contributor

Looks like we're getting a test failure on Scala, possibly related to #4809. Can we also add a test for this?

@fokot fokot force-pushed the mutablespec-layers-fix branch from da8f132 to 4b1c4b4 Compare May 2, 2021 09:16
adamgfraser
adamgfraser reviewed May 3, 2021
View reviewed changes
adamgfraser
adamgfraser previously approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment but otherwise looks good. The Scala 3 issue is not great but I think that needs to be solved at the level of the tag machinery rather than here.

@fokot
Copy link
Contributor Author

fokot commented May 7, 2021

@adamgfraser ready to merge

adamgfraser
adamgfraser previously approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@adamgfraser
Copy link
Contributor

@fokot Can you run prepare?

@fokot
Copy link
Contributor Author

fokot commented May 8, 2021

@adamgfraser done

@adamgfraser adamgfraser merged commit c8fd1e8 into zio:master May 8, 2021
@fokot fokot deleted the mutablespec-layers-fix branch May 8, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adamgfraser adamgfraser adamgfraser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MutableSpec: the TestEnvironment layer is shared between tests

2 participants

@fokot @adamgfraser