Implement Refined Gen instances (#4602) #5144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary parentheses Implement hex char gens Implement DigitInstances Implement NetInstances Add types package Implement CharInstances Implement NumericInstances Implement StringInstances Implement string DeriveGens Implement TimeInstances Fix range
adamgfraser
suggested changes
May 25, 2021
| */ | ||
| def filterNot(f: A => Boolean): Gen[R, A] = | ||
| filter(a => !(f(a))) | ||
| filter(a => !f(a)) |
There was a problem hiding this comment.
Minor refactoring.
Shouldn't I commit this change in this PR?
There was a problem hiding this comment.
No need to add additional parentheses to code that is already compiling.
There was a problem hiding this comment.
Yeah, I removed unnecessary parentheses.
| def fromIterable[R, A]( | ||
| as: Iterable[A], | ||
| shrinker: (A => ZStream[R, Nothing, A]) = defaultShrinker | ||
| shrinker: A => ZStream[R, Nothing, A] = defaultShrinker |
There was a problem hiding this comment.
Minor refactoring.
Shouldn't I commit this change in this PR?
Co-authored-by: Adam Fraser <[email protected]>
adamgfraser
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.