Update officials.md #5216
Merged
Update officials.md #5216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update docs to reflect the renaming of zio-web to zio-microservice (also mention other protocols in the summary)
|
|
adamgfraser
reviewed
Jun 18, 2021
| - [ZIO Akka Cluster](https://github.com/zio/zio-akka-cluster) — A ZIO wrapper for Akka Cluster | ||
| - [ZIO Config](https://github.com/zio/zio-config) — A ZIO based configuration parsing library | ||
| - [ZIO Web](https://github.com/zio/zio-web) — A ZIO-powered HTTP server and client | ||
| - [ZIO Microservice](https://github.com/zio/zio-microservice) — A ZIO-powered microservices via HTTP and other protocols |
There was a problem hiding this comment.
Suggested change
| - [ZIO Microservice](https://github.com/zio/zio-microservice) — A ZIO-powered microservices via HTTP and other protocols | |
| - [ZIO Microservice](https://github.com/zio/zio-microservice) — ZIO-powered microservices via HTTP and other protocols |
There was a problem hiding this comment.
Can you also alphabetize?
There was a problem hiding this comment.
@adamgfraser I kept the A for consistency with the other entries in the list. They all start with A. So I would suggest all are dropped or we keep this one as well.
There was a problem hiding this comment.
@mkows As currently written it is grammatically incorrect because "microservices" is being used as an adjective and there is no noun.
There was a problem hiding this comment.
Right. Good point. Updated.
adamgfraser
suggested changes
Jun 18, 2021
adamgfraser
approved these changes
Jul 2, 2021
|
Thanks @adamgfraser for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update docs to reflect the renaming of zio-web to zio-microservice (also mention other protocols in the summary)