Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Smart assert bug-fix and better array equality #5294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2021
Merged

Smart assert bug-fix and better array equality #5294

merged 2 commits into from
Jul 10, 2021

Conversation

@kitlangton
Copy link
Member

Fixed a bug received on Discord from TimP:

  trait Parent
  case class Child(x: String) extends Parent

  def testcontains = test("contains") {
    val someParent: Option[Parent] = None
    val someChild = Child("hi")
    assertTrue(someParent.contains(someChild))
  }

Also—from another feature request—I've made == on in a assertTrue for Arrays use sameElements under the hood, similar to the old equalTo assertion.

@kitlangton kitlangton changed the title Smart assert bugfix and array equaliy Smart assert bug-fix and better array equality Jul 10, 2021
@adamgfraser adamgfraser merged commit 087daaf into zio:master Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adamgfraser adamgfraser adamgfraser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kitlangton @adamgfraser