Implement Specialized Version Of Register Function For ZStream.effectAsync #5397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Thanks, @adamgfraser! I think a benefit of this, besides clarifying the somewhat confusing signature ( |
kitlangton
reviewed
Aug 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a specialized version of the register function in
ZStream.effectAsync. This is compatible with all existing code sinceRegisteris just a more specific version of the previous register function.This lets us implement some additional convenience methods on
Registerfor emitting a single value or a chunk of values, failing, ending, and so on.It does add an additional layer of indirection to the type signature of
effectAsync, but the existing one is already relatively complicated so not sure this is a step back.Copying @kitlangton.