Update Migration Guide: Unsafe Marker #6972
Conversation
| > Note: | ||
| > | ||
| > In ZIO 2.x, the `ZIO#provide` method—together with its variant `ZIO#provideSome`—is a default and easier way of injecting dependencies to the environmental effect. We do not require creating the dependency graph manually, it will be automatically generated. In contrast, the `ZIO#provideLayer`—and its variant `ZIO#provideSomeLayer`—is useful for low-level and custom cases like. | ||
| > In ZIO 2.x, the `ZIO#provide` method—and all its variants `ZIO#provideSome`, `ZIO#provideCustom`—is a default and easier way of injecting dependencies to the environmental effect. We do not require creating the dependency graph manually, it will be automatically generated. In contrast, the `ZIO#provideLayer`—and all its variants `ZIO#provideSomeLayer`, `ZIO#provideCustomLayer`—is useful for low-level and custom cases like. |
There was a problem hiding this comment.
I think this is an unnecessary change. There was another PR that we merged to delete references to provideCustom since it was deleted.
There was a problem hiding this comment.
Weird change! Wondering how it comes to my commits :)
Fixed!
|
|
||
| In ZIO 1.x, we used the `zio.Runtime.unsafeRun` method to run a ZIO workflow: | ||
|
|
||
| ```scala |
There was a problem hiding this comment.
Would be good to use mdoc on these examples where possible so we test that they compile.
There was a problem hiding this comment.
I agree, but some of them are based on ZIO 1.x, one of them is just a diff snippet based on ZIO 2.x, some of them are just simplified definitions of the API, and one another is based on scala 3. All of these are not type-safe.
Fortunately, the final snippet has a type-safe mdoc modifier.
|
|
||
| For example, if we wanted to integrate a ZIO workflow with a legacy unsafe code, we used to write something like this: | ||
|
|
||
| ```scala |
There was a problem hiding this comment.
Do you want to do the migration table for Runtime.unsafe*** here or in a separate PR?
|
|
||
| | | ZIO 1.0 | ZIO 2.x | | ||
| |---------|----------------------------|-------------------------------------------------------------| | ||
| | Scala 2 | `zio.Runtime.unsafeRun(x)` | `Unsafe.unsafe{ implicit u => zio.Runtime.unsafe.run(x) }` | |
There was a problem hiding this comment.
@khajavi Would be good to add the other unsafeRun variants from ZIO 1.0 to this table.
No description provided.