Cats MTL instances: ApplicativeAsk and ApplicativeLocal #705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Beautiful! On the cats-mtl dependency, what are your thoughts @Kaishh? |
|
The dependency is |
jdegoes
approved these changes
Mar 28, 2019
ghostdogpr
pushed a commit
to ghostdogpr/scalaz-zio
that referenced
this pull request
May 5, 2019
* ApplicativeAsk instances * ApplicativeLocal instance and tests * Formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few other typeclasses that might be worth implementing but as a first try I think these two are the most important now that ZIO is a trifunctor able to carry context.
I added the
cats-mtldependency to theinterop-catsmodule, meaning that users will pull this dependency even if they don't use it so maybe we can create a newinterop-cats-mtlmodule?