fix: fixed tapSomeError return type #7221
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdegoes
reviewed
Aug 23, 2022
| final def tapSomeError[R1 <: R, E1 >: E, A1 >: A]( | ||
| f: PartialFunction[E, ZIO[R1, E1, A1]] | ||
| )(implicit ev: CanFail[E], trace: Trace): ZIO[R1, E1, A1] = | ||
| )(implicit ev: CanFail[E], trace: Trace): ZIO[R1, E1, A] = |
There was a problem hiding this comment.
It looks to me like f passed to tapSomeError does not need to take a parameter A1 and can simply read like:
final def tapSomeError[R1 <: R, E1 >: E](
f: PartialFunction[E, ZIO[R1, E1, Any]]
)(implicit ev: CanFail[E], trace: Trace): ZIO[R1, E1, A] =|
@guihardbastien Thanks for your work in this! Picked up this change in #7222. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed tapSomeError return type
minor changes in tests
Co-authored by @dylandoamaral