Reduce Int boxing using IntFunction #7368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shawjef3 Looks like this just needs a format. |
|
@adamgfraser I fixed the formatting. Any preference between the two patches? |
jdegoes
approved these changes
Nov 23, 2022
|
@shawjef3 Thanks, merged this in (and closed the other one), as it seems more direct! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found these
Integerallocations while profilingZIO.fromCompletableFuture(CompletableFuture.completedFuture(())).forever. I performed the measurements the same way as #7365. Again I show before and after. See that thejava.lang.Integerallocations disappear.This implementation replaces the Scala
FunctioninZIO.UpdateRuntimeFlagsWithin.Dynamicwith Java'sIntFunction.Only accept this PR or #7367.