Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve Chunk.empty concatenation 50x for 1.x #7399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Improve Chunk.empty concatenation 50x for 1.x #7399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 37 additions & 31 deletions core/shared/src/main/scala/zio/Chunk.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,45 +50,51 @@ sealed abstract class Chunk[+A] extends ChunkLike[A] { self =>
* Returns the concatenation of this chunk with the specified chunk.
*/
final def ++[A1 >: A](that: Chunk[A1]): Chunk[A1] =
(self, that) match {
case (Chunk.AppendN(start, buffer, bufferUsed, _), that) =>
val chunk = Chunk.fromArray(buffer.asInstanceOf[Array[A1]]).take(bufferUsed)
start ++ chunk ++ that
case (self, Chunk.PrependN(end, buffer, bufferUsed, _)) =>
val chunk = Chunk.fromArray(buffer.asInstanceOf[Array[A1]]).takeRight(bufferUsed)
self ++ chunk ++ end
case (self, that) =>
val diff = that.depth - self.depth
if (math.abs(diff) <= 1) Chunk.Concat(self, that)
else if (diff < -1) {
if (self.left.depth >= self.right.depth) {
val nr = self.right ++ that
Chunk.Concat(self.left, nr)
} else {
val nrr = self.right.right ++ that
if (nrr.depth == self.depth - 3) {
val nr = Chunk.Concat(self.right.left, nrr)
if (isEmpty) {
that
} else if (that.isEmpty) {
self
} else {
(self, that) match {
case (Chunk.AppendN(start, buffer, bufferUsed, _), that) =>
val chunk = Chunk.fromArray(buffer.asInstanceOf[Array[A1]]).take(bufferUsed)
start ++ chunk ++ that
case (self, Chunk.PrependN(end, buffer, bufferUsed, _)) =>
val chunk = Chunk.fromArray(buffer.asInstanceOf[Array[A1]]).takeRight(bufferUsed)
self ++ chunk ++ end
case (self, that) =>
val diff = that.depth - self.depth
if (math.abs(diff) <= 1) Chunk.Concat(self, that)
else if (diff < -1) {
if (self.left.depth >= self.right.depth) {
val nr = self.right ++ that
Chunk.Concat(self.left, nr)
} else {
val nl = Chunk.Concat(self.left, self.right.left)
Chunk.Concat(nl, nrr)
val nrr = self.right.right ++ that
if (nrr.depth == self.depth - 3) {
val nr = Chunk.Concat(self.right.left, nrr)
Chunk.Concat(self.left, nr)
} else {
val nl = Chunk.Concat(self.left, self.right.left)
Chunk.Concat(nl, nrr)
}
}
}
} else {
if (that.right.depth >= that.left.depth) {
val nl = self ++ that.left
Chunk.Concat(nl, that.right)
} else {
val nll = self ++ that.left.left
if (nll.depth == that.depth - 3) {
val nl = Chunk.Concat(nll, that.left.right)
if (that.right.depth >= that.left.depth) {
val nl = self ++ that.left
Chunk.Concat(nl, that.right)
} else {
val nr = Chunk.Concat(that.left.right, that.right)
Chunk.Concat(nll, nr)
val nll = self ++ that.left.left
if (nll.depth == that.depth - 3) {
val nl = Chunk.Concat(nll, that.left.right)
Chunk.Concat(nl, that.right)
} else {
val nr = Chunk.Concat(that.left.right, that.right)
Chunk.Concat(nll, nr)
}
}
}
}
}
}

final def ++[A1 >: A](that: NonEmptyChunk[A1]): NonEmptyChunk[A1] =
Expand Down