document fromAutoClosable #7575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This answers the typical beginner question when working with ZIO and resources "how do I do try-with-resource in ZIO"
only readAllBytes should be limited to IOException, FileInputStream might return a FileNotFoundException
|
I adapted the PR a bit, to use attemptBlocking instead of attemptBlockingIO when opening the FileInputStream I believe the failing zio.test.RandomSpec is not caused by my change, otherwise I'm happy to learn how I managed to break it. |
adamgfraser
reviewed
Nov 30, 2022
adamgfraser
reviewed
Nov 30, 2022
Co-authored-by: Adam Fraser <[email protected]>
adamgfraser
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This answers the typical beginner question when working with ZIO and resources "how do I do try-with-resource in ZIO"