Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Removed anti-pattern in good example #7579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Removed anti-pattern in good example #7579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 14 additions & 15 deletions docs/reference/di/zlayer-constructor-as-a-value.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,18 +342,20 @@ object UserRepositoyLive {
We should avoid using blocking operations inside Scala constructors:

```scala mdoc:compile-only
class KafkaProducer {
class ProducerInput

class KafkaProducer(input: ProducerInput) {
def send(message: String): Unit = ???
}

object KafkaProducer {
def apply() = {
// Blocking operation, we should avoid it inside constructors
doSomeBlockingOperation()
new KafkaProducer()
val input = doSomeBlockingOperation()
new KafkaProducer(input)
}
private def doSomeBlockingOperation(): Unit = ???

private def doSomeBlockingOperation(): ProducerInput = ???
}
```

Expand All @@ -362,24 +364,21 @@ While with `ZLayer`, we can easily use blocking operations:
```scala mdoc:compile-only
import zio._

class KafkaProducer {
def send(message: String): Task[Unit] = ???
class ProducerInput

class KafkaProducer(input: ProducerInput) {
def send(message: String): Task[Unit] = ???
}

object KafkaProducer {
def apply() = {
doSomeBlockingOperation()
new KafkaProducer()
}

val layer =
ZLayer {
for {
_ <- ZIO.attemptBlocking(doSomeBlockingOperation())
} yield (new KafkaProducer())
input <- ZIO.attemptBlocking(doSomeBlockingOperation())
} yield (new KafkaProducer(input))
}

private def doSomeBlockingOperation(): Unit = ???
private def doSomeBlockingOperation(): ProducerInput = ???
}
```

Expand Down