Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix suiteAll error channel #7643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Fix suiteAll error channel #7643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed6cc13
Fix suiteAll error channel
swoogles Dec 16, 2022
672d4b0
+SuiteAllSpec ignored test to confirm failing specs compile now
swoogles Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test-tests/shared/src/test/scala/zio/test/SuiteAllSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package zio.test
import zio._
import zio.test.TestAspect.ignore

object SuiteAllSpec extends ZIOSpecDefault {

Expand Down Expand Up @@ -29,6 +30,11 @@ object SuiteAllSpec extends ZIOSpecDefault {
assertCompletes
)
}
suiteAll("a") {
test("b") {
ZIO.fail("boom").as(assertCompletes)
} @@ ignore
}

}
.provide(ZLayer.succeed(123))
Expand Down
2 changes: 1 addition & 1 deletion test/shared/src/main/scala-2/zio/test/SmartSpecMacros.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ class SmartSpecMacros(val c: whitebox.Context) {
val refined = internal.refinedType(allEnvs, c.prefix.tree.symbol)

q"""
val specBuffer = scala.collection.mutable.ListBuffer.empty[Spec[$refined,Nothing]]
val specBuffer = scala.collection.mutable.ListBuffer.empty[Spec[$refined,Any]]
..${acc.reverse}
_root_.zio.test.suite($name)(
specBuffer.toList:_*
Expand Down
2 changes: 1 addition & 1 deletion test/shared/src/main/scala-2/zio/test/ZIOSpecVersionSpecific.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ package zio.test
trait ZIOSpecVersionSpecific[R] {
// SCALA 2

def suiteAll(name: String)(spec: Any): Spec[Nothing, Nothing] =
def suiteAll(name: String)(spec: Any): Spec[Nothing, Any] =
macro SmartSpecMacros.suiteImpl
}