Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@adamgfraser
Copy link
Contributor

There is a race condition in this test. It is trying to assert that the upstream can progress independently of the downstream in buffer by having the downstream read two elements and asserting that the upstream writes those two elements plus another two. However, the downstream can close the stream after it has read two elements which will shut down the queue and interrupt the upstream when it writes the third element.

We can prevent this by using runScoped to have the downstream read two elements without closing the scope of the stream as we do in some tests for other variants of this operator.

@adamgfraser adamgfraser requested review from jdegoes and vigoo January 4, 2023 03:01
@swoogles swoogles merged commit 446c949 into zio:series/2.x Jan 4, 2023
@adamgfraser adamgfraser deleted the buffer branch January 4, 2023 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants