Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix delim-splitting for Config.secret #7722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix delim-splitting for Config.secret #7722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions core-tests/shared/src/test/scala/zio/ConfigProviderEnvSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,12 @@ object ConfigProviderEnvSpec extends ZIOBaseSpec {
_ <- TestSystem.putEnv("ADDRESS", "221B Baker Street")
config <- ConfigProvider.envProvider.load(Config.table(Config.string))
} yield assertTrue(config == Map("NAME" -> "Sherlock Holmes", "ADDRESS" -> "221B Baker Street"))
} +
test("load secret without splitting by seqDelim") {
for {
_ <- TestSystem.putEnv("SECRET", "a,b")
config <- ConfigProvider.envProvider.load(Config.secret("SECRET"))
} yield assertTrue(config == Config.Secret("a,b"))
}
}
}
2 changes: 1 addition & 1 deletion core/shared/src/main/scala/zio/ConfigProvider.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ object ConfigProvider {
escapedDelim: String
): IO[Config.Error, Chunk[A]] = {
val name = path.lastOption.getOrElse("<unnamed>")
val unsplit = primitive == Config.Secret
val unsplit = primitive == Config.SecretType

if (unsplit) ZIO.fromEither(primitive.parse(text)).map(Chunk(_))
else
Expand Down