Return To Default Executor More Eagerly #7749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a great change and was also implemented in the old runtime. 👍 |
jdegoes
approved these changes
Jan 27, 2023
jdegoes
approved these changes
Jan 27, 2023
|
If you have the chance, would be good to add a test for this to ensure we don't break. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user hasn't specified that we are supposed to run on any executor then after
zio.onExecutor(executor)completes we continue executing on the current executor for efficiency.However, we should return to the default executor the next time we yield since we are incurring the cost of a yield regardless so we don't continue running on a potentially suboptimal executor indefinitely.
This requires keeping track of one more piece of information in the runtime of the executor that is currently running the fiber so we know when we shift to a new executor whether we actually need to yield or whether we happen to already be running on that executor.