Add Annotations To Cause #7808
Merged
Add Annotations To Cause #7808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fantastic! I would also capture log spans, but not fiber refs. ZIO Logging is going to try to use ordinary annotations for typed logged annotations by pre-rendering to a string. |
|
Done! |
jdegoes
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7778.
Adds annotations to
Cause. The annotations are currently aMap[String, String]. One open question is whether we want to add additional data here. For example, inZLoggerwe also capture the log spans and the currentFiberRefvalues, which can be used to implement typed log annotations.The default rendering of
Causeis also unchanged, so this data is available for more advanced applications that want to expose it but the stack trace continues to look like a Java stack trace, though we could potentially revisit that.