Merge series/1.x to series/2.x #7853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… versions in ZIO 2.0 (zio#6478)
* Update Scala.js and Scala Native to last supporting 2.11 * update Scala versions * update Silencer versions * lower Scala versions
# Conflicts: # .github/workflows/ci.yml # build.sbt # core-tests/shared/src/test/scala/zio/ScheduleSpec.scala # core/shared/src/main/scala/zio/Schedule.scala
|
@mijicd @adamgfraser Please merge as Merge commit (not Squash commit) 🙏 |
This was referenced Feb 22, 2023
15fa8b3 to
f16d929
Compare
adamgfraser
approved these changes
Feb 22, 2023
|
Good to be merged @adamgfraser @mijicd 🎉 |
sideeffffect
commented
Feb 22, 2023
| // Once it's available, this should be merged together with the `js-jvm` variant back to `shared`. | ||
| // https://github.com/scala-native/scala-native/pull/3127 | ||
| private[zio] trait UpdateRuntimeFlagsWithinPlatformSpecific { | ||
| type RuntimeFlagsFunc[A] = Int => A |
There was a problem hiding this comment.
btw, do we need to mark it as private[zio] too?
There was a problem hiding this comment.
I think if the trait is package private and the only object that extends it is package private there is no need for the members to be package private as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please merge as Merge commit (not Squash commit) 🙏