Optimize ZIO.attempt #7920
Merged
Optimize ZIO.attempt #7920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigoo
approved these changes
Mar 14, 2023
|
This does mean that if a fatal error does occur we need to execute one more workflow after that to get the definition of a fatal error so maybe this doesn't make sense. |
|
I wonder if we should just intern it. |
|
Isn't the problem that the definition of a fatal error is itself a regional setting stored in a |
|
All right, sounds good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can make this slightly faster by only looking up the definition of a fatal error if an exception is thrown.