Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@johnspade
Copy link
Contributor

@johnspade johnspade commented Mar 22, 2023

I calculate OpenTracing tags in library code, and sometimes it's more convenient to return a noop object from a condition rather than dealing with an Option/List. Empty/noop objects like this are often useful.

@johnspade johnspade marked this pull request as ready for review March 22, 2023 09:59
Copy link
Contributor

@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one minor comment on naming.

Co-authored-by: Adam Fraser <[email protected]>
@johnspade johnspade changed the title Add ZIOAspect.noop Add ZIOAspect.identity Mar 22, 2023
@adamgfraser adamgfraser merged commit 9ae4b54 into zio:series/2.x Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants