LogLevel config #7937
LogLevel config #7937
Conversation
| val Trace: LogLevel = LogLevel(0, "TRACE", 7) | ||
| val None: LogLevel = LogLevel(Int.MaxValue, "OFF", 7) | ||
|
|
||
| val config: Config[LogLevel] = Config.string.mapOrFail { value => |
There was a problem hiding this comment.
I think this should probably be in the Config companion object. Organizing principle would be configurations for all ZIO and standard library data types are in the Config companion object, and all other configurations are defined in the companion object of the data type.
| } | ||
| } | ||
|
|
||
| val logLevelMapping: Map[String, LogLevel] = Map( |
There was a problem hiding this comment.
We should make this private.
There was a problem hiding this comment.
i did not make it private, as it can be used in zio-logging to get all LogLevel values and for similar cases,
but we can find some alternative ...
There was a problem hiding this comment.
Better to make LogLevel.levels expose all log levels.
| case NonFatal(e) => Left(Config.Error.InvalidData(Chunk.empty, s"Expected a local time value, but found ${text}")) | ||
| } | ||
| } | ||
| case object LogLevelType extends Primitive[LogLevel] { |
There was a problem hiding this comment.
We should not introduce additional primitives here.
There was a problem hiding this comment.
should it be just
def logLevel: Config[LogLevel] = Config.string.mapOrFail { value =>
LogLevel.logLevelMapping.get(value.toUpperCase) match {
case Some(v) => Right(v)
case None => Left(Config.Error.InvalidData(Chunk.empty, s"Expected a log level, but found ${value}"))
}
}?
| LogLevel.None | ||
| ) | ||
|
|
||
| private[zio] val levelMapping: Map[String, LogLevel] = levels.map(level => (level.label, level)).toMap |
There was a problem hiding this comment.
I think we can just inline this into the implementation of Config.logLevel at this point.
levels.collectFirst { case logLevel if logLevel.label == value.toUpperCase => ??? }| LogLevel.Error.label -> LogLevel.Error, | ||
| LogLevel.Fatal.label -> LogLevel.Fatal, | ||
| LogLevel.None.label -> LogLevel.None | ||
| val levels: Chunk[LogLevel] = Chunk( |
There was a problem hiding this comment.
This should possibly just be a set.
added configuration for
LogLevel