Call sizeHint in Chunk.fromJavaIterable when possible
#7954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
reviewed
Mar 27, 2023
| * access to the size of the list, which allows us to optimize the chunk | ||
| * building process. | ||
| */ | ||
| def fromJavaList[A](list: java.util.List[A]): Chunk[A] = { |
There was a problem hiding this comment.
But I think you can test if the passing in is a List in fromJavaIterable too.
There was a problem hiding this comment.
@He-Pin I made the change. I used java.util.Collection instead of java.util.List as java.util.List is extending java.util.Collection and it also has this abstract size method.
Let me know what you think :)
Chunk.fromJavaListsizeHint in Chunk.fromJavaIterable when possible
adamgfraser
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.