Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix nesting for indexed ConfigProvider #7971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2023
Merged

Fix nesting for indexed ConfigProvider #7971

merged 1 commit into from
Apr 2, 2023

Conversation

@vladimirkl
Copy link
Contributor

This PR fixes ConfigProvider#nest and ConfigProvider#unnest for indexed data. Currently this doesn't work at all:

val provider = ConfigProvider.fromMap(Map( "parent.child.employees[0].age" -> "1")).nested("child").nested("parent")
val product = Config.int("age").zip(Config.int("id"))
val config  = Config.listOf("employees", product)

configProvider.load(config) // Fails with exception

@adamgfraser adamgfraser merged commit f886c86 into zio:series/2.x Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adamgfraser adamgfraser adamgfraser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vladimirkl @adamgfraser