Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Optimize ZSink.collectAllN #7987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2023
Merged

Optimize ZSink.collectAllN #7987

merged 1 commit into from
Apr 5, 2023

Conversation

@adamgfraser
Copy link
Contributor

No description provided.

@adamgfraser adamgfraser requested review from jdegoes and vigoo April 4, 2023 23:55
vigoo
vigoo approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@vigoo vigoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment "Note that the chunk is preallocated and must fit in memory." is not true now

@jdegoes jdegoes merged commit 2555063 into zio:series/2.x Apr 5, 2023
@adamgfraser adamgfraser deleted the collectalln branch April 5, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdegoes jdegoes jdegoes approved these changes

@vigoo vigoo vigoo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adamgfraser @jdegoes @vigoo