Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed #7972 - Fix mdoc compile warnings #8005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 12, 2023
Merged

Fixed #7972 - Fix mdoc compile warnings #8005

merged 4 commits into from
Apr 12, 2023

Conversation

@abdheshkumar
Copy link
Contributor

I could not fixed below warnings because <DocCardList /> generates dynamic links

info: Compiling 1 file to /Users/abdkumar/Desktop/expedia/zio/website/docs
warning: reference/observability/logging.md:61:3: Unknown link 'ecosystem/officials/zio-logging.md', did you mean 'ecosystem/officials/index.md'?
* [ZIO Logging](../../ecosystem/officials/zio-logging.md)
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
warning: reference/observability/tracing.md:11:126: Unknown link 'ecosystem/officials/zio-telemetry.md', did you mean 'ecosystem/officials/index.md'?
ZIO Telemetry supports tracing through the OpenTelemetry API. To learn more about tracing, please refer to the ZIO Telemetry [documentation](../../ecosystem/officials/zio-telemetry.md).
                                                                                                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
info: Compiled in 4.91s (0 errors, 2 warnings)

@CLAassistant
Copy link

CLAassistant commented Apr 10, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@abdheshkumar abdheshkumar mentioned this pull request Apr 10, 2023
Closed
@adamgfraser adamgfraser requested a review from khajavi April 11, 2023 00:24
@khajavi
Copy link
Member

khajavi commented Apr 11, 2023

@abdheshkumar
Could you make adjustments to the settings so that warnings are treated as errors? This will ensure that the CI fails if there are any documentation warnings.

@abdheshkumar
Copy link
Contributor Author

@abdheshkumar Could you make adjustments to the settings so that warnings are treated as errors? This will ensure that the CI fails if there are any documentation warnings.

image

@adamgfraser adamgfraser merged commit b3be3aa into zio:series/2.x Apr 12, 2023
@abdheshkumar abdheshkumar deleted the feature/fix-broken-doc branch April 12, 2023 13:57
@renovate renovate bot mentioned this pull request Jan 4, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khajavi khajavi khajavi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@abdheshkumar @CLAassistant @khajavi @adamgfraser