Test output refactoring #8031
Merged
Test output refactoring #8031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was exposing way more implementation than needed.
|
Sorry, I was away for a bit! Looks like a great refactoring! Any change that removes manual layers assembly in favor of |
hmemcpy
approved these changes
Apr 15, 2023
adamgfraser
approved these changes
Apr 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was too much assembly required to use
ExecutionEventSink.Instead of exposing all the individual pieces and assembling it in the
TestRunner, things are assembled internally now.I was able to remove
TestOutputfrom the environments of a few methods after this change.Also made some of the naming more consistent, and privatized a few pieces that shouldn't have been exposed in the first place.