Show message when using unsupported by-name parameters #8117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamgfraser
reviewed
May 14, 2023
build.sbt
Outdated
| .dependsOn(testRunner) | ||
| .settings(buildInfoSettings("zio")) | ||
| .settings(publish / skip := true) | ||
| .settings( |
There was a problem hiding this comment.
You can use the typecheck operator in ZIO Test for this. There is no need for a third party dependency.
b5e25b2 to
4fa246e
Compare
|
I forgot about copy one ... I'll add it EDIT: I've tested copy and cannot reproduce it - my guess is that propably it was only the by-name thing |
jdegoes
reviewed
May 15, 2023
| for (layer <- layers) { | ||
| layer.tree match { | ||
| case apply @ Apply(_, Block(_, _) :: Nil) => { | ||
| c.abort(layer.tree.pos, "Cannot use by-name parameters") |
There was a problem hiding this comment.
Can you tweak this error message to explain:
- What's going wrong, in detail (a user might not have ever heard of "by-name" parameters)
- Why it's going wrong, e.g., what problem is introduced by by-name parameters that prevents their invocation from appearing as input to provide
- What the user can do to fix the problem
There was a problem hiding this comment.
I've created following error message:
──── ZLAYER ERROR ────────────────────────────────────────────────────
Due to bug in Scala 2 compiler invoking methods with by-name parameters in provide/provideSome method does not work
def createLayerByName(i: Int, x: => MyLayer): zio.ULayer[MyLayer]
Bug can be workarounded in following ways:
1. Assign method output to temporary variable
ZLayer.provide(createLayerByName(...))
↓↓↓
val temp = createLayerByName(...)
ZLayer.provide(temp)
2. Replace by-name parameter with lambda:
def createLayerByName(i: Int, x: => MyLayer): zio.ULayer[MyLayer]
↓↓↓
def createLayerByName(i: Int, x: () => MyLayer): zio.ULayer[MyLayer]
──────────────────────────────────────────────────────────────────────
jdegoes
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not really fixable on ZIO side, but at least better error message can be shown.
Fixes #7732
/claim #7732