Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix nesting for ConfigProvider#orElse #8156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2023
Merged

Fix nesting for ConfigProvider#orElse #8156

merged 1 commit into from
May 30, 2023

Conversation

@vladimirkl
Copy link
Contributor

This PR fixes ConfigProvider#orElse which currently doesn't work with combination of nesting and indexed data:

val configProvider =
  ConfigProvider.fromMap(Map("employees[0].age" -> "1")).unnested("parent1") orElse
    ConfigProvider.fromMap(Map("employees[0].age" -> "2")).unnested("parent2")

val config = Config.listOf("employees", Config.int("age")).nested("parent1")

configProvider.load(config) // Fails with missing data error

Also added a bit more tests for orElse to avoid regressions

@adamgfraser adamgfraser merged commit 1181cf2 into zio:series/2.x May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adamgfraser adamgfraser adamgfraser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vladimirkl @adamgfraser