Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Do Not Hold On To References In Unbounded Hub #8294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Do Not Hold On To References In Unbounded Hub #8294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 29 additions & 21 deletions core/jvm/src/main/scala/zio/internal/UnboundedHub.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,11 @@ import java.util.concurrent.atomic._
private final class UnboundedHub[A] extends Hub[A] {
import UnboundedHub._

private[this] val empty = new Node[A](null.asInstanceOf[A], new AtomicReference(Pointer(null, 0)))
private[this] val publisherHead = new AtomicReference(empty)
private[this] val publisherTail = new AtomicReference(empty)
private[this] val publisherHead: AtomicReference[Node[A]] =
new AtomicReference(new Node[A](null.asInstanceOf[A], new AtomicReference(Pointer(null, 0))))

private[this] val publisherTail: AtomicReference[Node[A]] =
new AtomicReference(publisherHead.get)

val capacity: Int =
Int.MaxValue
Expand Down Expand Up @@ -144,27 +146,32 @@ private final class UnboundedHub[A] extends Hub[A] {
}
}

def subscribe(): Hub.Subscription[A] =
new Hub.Subscription[A] {
private[this] var currentPublisherTail = null.asInstanceOf[Node[A]]
private[this] var loop = true
while (loop) {
currentPublisherTail = publisherTail.get
val currentPointer = currentPublisherTail.pointer.get
val currentNode = currentPointer.node
if (currentPublisherTail eq publisherTail.get) {
if (currentNode eq null) {
val updatedPointer = currentPointer.copy(subscribers = currentPointer.subscribers + 1)
if (currentPublisherTail.pointer.compareAndSet(currentPointer, updatedPointer)) {
loop = false
}
} else {
publisherTail.compareAndSet(currentPublisherTail, currentNode)
def subscribe(): Hub.Subscription[A] = {
var currentPublisherTail = null.asInstanceOf[Node[A]]
var loop = true
while (loop) {
currentPublisherTail = publisherTail.get
val currentPointer = currentPublisherTail.pointer.get
val currentNode = currentPointer.node
if (currentPublisherTail eq publisherTail.get) {
if (currentNode eq null) {
val updatedPointer = currentPointer.copy(subscribers = currentPointer.subscribers + 1)
if (currentPublisherTail.pointer.compareAndSet(currentPointer, updatedPointer)) {
loop = false
}
} else {
publisherTail.compareAndSet(currentPublisherTail, currentNode)
}
}
private[this] val subscriberHead = new AtomicReference(currentPublisherTail)
private[this] val unsubscribed = new AtomicBoolean(false)
}

new Hub.Subscription[A] {

private[this] val subscriberHead: AtomicReference[Node[A]] =
new AtomicReference(currentPublisherTail)

private[this] val unsubscribed: AtomicBoolean =
new AtomicBoolean(false)

def isEmpty(): Boolean = {
var empty = true
Expand Down Expand Up @@ -297,6 +304,7 @@ private final class UnboundedHub[A] extends Hub[A] {
}
}
}
}
}

private object UnboundedHub {
Expand Down