Clock::currentTime: Avoid calling unit.convert when the passed TimeUnit is MILLISECONDS
#8358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meUnit` is `MILLISECONDS`
0d5fbee to
4664de5
Compare
guizmaii
commented
Aug 29, 2023
| case TimeUnit.MICROSECONDS => | ||
| inst.getEpochSecond * 1000000 + inst.getNano / 1000 | ||
| case _ => unit.convert(inst.toEpochMilli, TimeUnit.MILLISECONDS) | ||
| case TimeUnit.MILLISECONDS => inst.toEpochMilli |
There was a problem hiding this comment.
I might be wrong but I'm not sure we need to call unit.convert in this case 🤔
adamgfraser
approved these changes
Aug 29, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.