Optimize Differ #8549
Merged
Optimize Differ #8549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swoogles
approved these changes
Nov 15, 2023
jdegoes
reviewed
Nov 15, 2023
| map - tag -> patch.combine(AddService(newService, tag)) | ||
| } | ||
| } | ||
| missingServices.foldLeft(patch) { case (patch, (tag, _)) => |
There was a problem hiding this comment.
There's unfortunately still massive allocation in here. I think we can do a few things:
- Short term, make sure the happy path (no differences) is special-cased and involves no allocations (actually, that's impossible, since you can't even look at the contents of a map without allocations, but we could get close) and minimal indirection;
- Long-term, see about NOT using Scala's Map for the environment, but rather switch to a register + array-based implementation that is ideal for "small maps", and could achieve minimal allocations for many operations.
There was a problem hiding this comment.
The first one is what we're doing here. If the two maps are the same just immediately return an empty patch. The second one we could definitely look at. I think the size we have to optimize for is approximately one hundred services so we just have to make sure we actually come out ahead there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.