optimize ZStream.absolve #8558
Merged
optimize ZStream.absolve #8558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulpdaniels
commented
Nov 18, 2023
| if (mapped.size == in.size) ZChannel.write(mapped) *> loop | ||
| else { | ||
| val firstError = in(mapped.size).asInstanceOf[Left[E, O]] | ||
| ZChannel.write(mapped) *> ZChannel.fail(firstError.value) |
There was a problem hiding this comment.
Read up to the error, these values can be safely written first, then the error can be written after. This will preserve maximum chunking until the "final" chunk that terminates the stream.
vigoo
approved these changes
Nov 18, 2023
adamgfraser
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under the hood ZStream.absolve was using
mapZIOwhich destroys chunking. Since the stream can only fail once with aLeftthis can be improved by optimizing for the happy path instead.