Fix findAncestor's parentDepth parameter usage
#8748
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conclusion: the tests still pass with this change and that worries me 😕 |
jdegoes
reviewed
Apr 16, 2024
jdegoes
reviewed
Apr 16, 2024
guizmaii
added a commit
to guizmaii/zio
that referenced
this pull request
Apr 17, 2024
guizmaii
added a commit
to guizmaii/zio
that referenced
this pull request
Apr 17, 2024
|
@guizmaii Good to merge when conflicts fixed and CI is passing. 👍 |
Implement John suggestion zio#8748 (comment) Implement John suggestion zio#8748 (comment) clean code
|
Superseded by #8765 because it was easier to re-apply the changes than to rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Issue" found while reviewing #8745 (See comment #8745 (comment))
I want to see if the test pass with this change
Change made in #8333 (Thanks @kyri-petrou for finding the change. See also #8745 (comment))